Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Replaced problem anonymous function. #8

Merged
merged 1 commit into from Nov 11, 2011
Merged

Conversation

philcali
Copy link
Contributor

It was recently brought to our attention that a particular anonymous function was causing troubles in quickmail::list_entries. This code aims to fix that problem by replacing the problem code with tried and true PHP.

@adamzap, please review.

@rrusso
Copy link
Contributor

rrusso commented Oct 24, 2011

Good catch.

On Oct 24, 2011, at 7:45 AM, "Philip Cali" reply@reply.github.com wrote:

It was recently brought to our attention that a particular anonymous function was causing troubles in quickmail::list_entries. This code aims to fix that problem by replacing the problem code with tried and true PHP.

@adamzap, please review.

You can merge this Pull Request by running:

git pull https://github.com/lsuits/quickmail remove_anonymous_func

Or you can view, comment on it, or merge it online at:

#8

-- Commit Summary --

  • Removed anonymous function, other minor refactorings.

-- File Changes --

M email.php (7)
M lib.php (19)

-- Patch Links --

https://github.com/lsuits/quickmail/pull/8.patch
https://github.com/lsuits/quickmail/pull/8.diff

Reply to this email directly or view it on GitHub:
#8

@adamzap
Copy link
Contributor

adamzap commented Oct 24, 2011

👍

Are the changes in email.php related?

@philcali
Copy link
Contributor Author

Minor refactoring. It was showing the notifyproblem coloring for draft saves.

@philcali
Copy link
Contributor Author

@rrusso, can you test this change when you get a chance. It should work the same, just more compatible for all versions of PHP.

@adamzap
Copy link
Contributor

adamzap commented Nov 8, 2011

@rrusso, have you tested this?

@rrusso
Copy link
Contributor

rrusso commented Nov 10, 2011

Yes. Please merge and close.

philcali added a commit that referenced this pull request Nov 11, 2011
Replaced problem anonymous function.
@philcali philcali merged commit a0d02f3 into master Nov 11, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants