Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Move "All users" to the top of the "Potential Groups" list #153

Open
abias opened this issue Aug 19, 2014 · 2 comments
Open

Move "All users" to the top of the "Potential Groups" list #153

abias opened this issue Aug 19, 2014 · 2 comments

Comments

@abias
Copy link

abias commented Aug 19, 2014

Hi,

I have seen that in the "Potential Groups" list, there is an entry "All users". When this entry is marked, the "Potential Groups" filter is in a "neutral position" and all users are selected.

Unfortunatelly, the first and default item of "Potential Groups" is "All groups". So, if I have users who aren't members of any group, they are not selected by default.

Can we move "All users" to the top of the "Potential Groups" list and make it the default?

Thanks,
Alex
@elliott2081 elliott2081 assigned elliott2081 and jpeak5 and unassigned elliott2081 Jan 14, 2015
@Kathrin84 Kathrin84 mentioned this issue Jun 1, 2015
Closed
elliott2081 added a commit that referenced this issue Jul 15, 2015
@elliott2081
Merge pull request #183 from Kathrin84/Fix-to-issue-#153-group-order
3f0319f 
Fix to issue #153
timb28 added a commit to HarcourtsAcademy/quickmail that referenced this issue Jan 20, 2016
@timb28
Merge branch 'MOODLE_STABLE_30' of https://github.com/lsuits/quickmail …
c728b85 
…into HA-Moodle30

# By David Elliott (8) and others
# Via David Elliott (7) and Robert Russo (1)
* 'MOODLE_STABLE_30' of https://github.com/lsuits/quickmail:
  Updated version for upgrades
  fixed typo that was messing up restore functionality
  Version stuffs for Moodle 3.x
  getting rid of jasons generator code, can still be found in that specific repo
  deleted unnecessary jquery file
  fixed spacing issue if the user has a signature selected.
  Made changes to email.php that should finally fix the plain text formatting issues, to just standard moodle way of handling plain text formats
  small comment change
  Fix to lsuits#147
  Fix to issue lsuits#153
  Migrating add_to_log call for Quickmail lsuits#180
  trying out a better way of formatting, using moodle functions, instead of just strip_tags
  include jquery correctly
  just adding some tags
  Moved icons into content->items and leave content->icons empty. So that it is consistent with the pattern of all the other blocks.
  Removing outdated lang files
@rrusso
Copy link
Contributor

rrusso commented Jun 20, 2017

This has been in prod and on Moodle's Plugin repo for a while.

@rrusso rrusso closed this as completed Jun 20, 2017
@Kathrin84
Copy link
Contributor

Kathrin84 commented Sep 22, 2017 •
edited

Hi,
I've encountered that "All users" are not displayed if there are no groups existing in the course and and still "All Groups" is highlighted by default.
I've written a patch for this. This patch displays "All users" always and "All Groups" and the related groups only if there are existing ones within the course.
Additionally, "All users" are highlighted by default.
#235
Best, Kathrin

@chadmazilly chadmazilly reopened this Sep 22, 2017
@Kathrin84 Kathrin84 mentioned this issue Oct 20, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@elliott2081 @rrusso @abias @jpeak5 @chadmazilly @Kathrin84