Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bogus date, workaround for CentOS7 'dist' value, remove trailling spaces #19

Merged
merged 3 commits into from Jan 29, 2018
Merged

Conversation

arekkusu
Copy link

See commit message. Fixes following issues: #15 #17

I removed the change to changelog from my previous pull request (#18).

Alexandre Rosenberg added 3 commits January 29, 2018 18:04
- Bogus date results in warming when building RPM
  - Bogu because Weekday does not match date

- Fixed assuming date are correct/wrong weekday
  - Used script 'BogusDateBot' (1)

(1) https://bugzilla.redhat.com/show_bug.cgi?id=1000019#c11
- CentOS7 sets dist value to '.el7.centos' instead of '.el7
  - Result in failing macro - missing build dependency cracklib-devel

- This seems to be the usual fix/workaround (1) (2)

(1) https://cstan.io/?p=8946&lang=en
(2) https://serverfault.com/questions/688485/rpm-dist-tag-not-behaving-as-documented
@coudot
Copy link
Member

coudot commented Jan 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants