Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ldap_bind return code instead of relying on ldap_errno #209

Closed
coudot opened this issue Jun 13, 2018 · 1 comment
Closed

Check ldap_bind return code instead of relying on ldap_errno #209

coudot opened this issue Jun 13, 2018 · 1 comment
Assignees
@coudot
Labels
bug security
Milestone
1.3

Comments

@coudot
Copy link
Member

coudot commented Jun 13, 2018 •
edited
Loading

As it can be seen in the issue open on php.pnet, the ldap_errno is not filled if there was an error when calling ldap_bind: https://bugs.php.net/bug.php?id=76469

We have a PR #208 that is workaround by checking that parameters are strings, but this does not prevent another ldap_bind error.

We need to check ldap_bind return code before looking at ldap_errno.
@coudot coudot self-assigned this Jun 13, 2018
@coudot coudot added this to the 1.3 milestone Jun 13, 2018
coudot added a commit that referenced this issue Jun 13, 2018
@coudot
Check ldap_bind return code for Manager account connection (#209)
11cf35e
coudot added a commit that referenced this issue Jun 13, 2018
@coudot
Code cleaning (#209)
463786b
coudot added a commit that referenced this issue Jun 13, 2018
@coudot
Check ldap_bind return code for user account connection (#209)
b6d89de
@coudot
Copy link
Member Author

coudot commented Jun 13, 2018

Done. We will also apply #208 to enforce security

@coudot coudot closed this as completed Jun 13, 2018
@cfasnacht cfasnacht mentioned this issue Jun 14, 2018
Closed
@coudot coudot mentioned this issue Jun 20, 2018
Closed
derhelge pushed a commit to derhelge/self-service-password that referenced this issue Jul 30, 2019
@coudot
Check ldap_bind return code for Manager account connection (ltb-proje…
5b5994b 
…ct#209)
derhelge pushed a commit to derhelge/self-service-password that referenced this issue Jul 30, 2019
@coudot
Code cleaning (ltb-project#209)
77224a3
derhelge pushed a commit to derhelge/self-service-password that referenced this issue Jul 30, 2019
@coudot
Check ldap_bind return code for user account connection (ltb-project#209
52f4a2a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coudot coudot

Labels
bug security
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
1 participant
@coudot