Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JS to prevent multiple submits #844

Closed
davidcoutadeur opened this issue Mar 6, 2024 · 1 comment · Fixed by #845
Closed

Added JS to prevent multiple submits #844

davidcoutadeur opened this issue Mar 6, 2024 · 1 comment · Fixed by #845
Assignees
@davidcoutadeur
Labels
enhancement
Milestone
1.6.0

Comments

@davidcoutadeur
Copy link

Proposition taken from @stevleibelt : #757

Original proposal:

I've added a little bit of javascript that disables the submit button once it is clicked.

The reason for that is to prevent users send the request form multiple times by clicking the submit button multiple times. If done so, this could result into an "false positive" error message that the password change was not successful.
@davidcoutadeur davidcoutadeur added this to the 1.6.0 milestone Mar 6, 2024
@davidcoutadeur davidcoutadeur self-assigned this Mar 6, 2024
@davidcoutadeur davidcoutadeur mentioned this issue Mar 6, 2024
Merged
@davidcoutadeur
Copy link
Author

davidcoutadeur commented Mar 6, 2024 •
edited

See complete discussion in PR #757

See my PR #845 for fixing the issue with a preventDefault function. Tested on my desktop successfully

@davidcoutadeur davidcoutadeur mentioned this issue Mar 6, 2024
Closed
coudot added a commit that referenced this issue Mar 7, 2024
@coudot
Merge pull request #845 from ltb-project/844-prevent-multiple-form-su…
c4f65e0 
…bmits

prevent multiple form submits (#844)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcoutadeur davidcoutadeur

Labels
enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

prevent multiple form submits (#844) ltb-project/self-service-password
1 participant
@davidcoutadeur