Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb cleanup #852

Closed
11 tasks done
davidcoutadeur opened this issue Mar 8, 2024 · 4 comments · Fixed by #858
Closed
11 tasks done

deb cleanup #852

davidcoutadeur opened this issue Mar 8, 2024 · 4 comments · Fixed by #858
Assignees
Milestone

Comments

@davidcoutadeur
Copy link

davidcoutadeur commented Mar 8, 2024

This is the issue equivalent to spec cleanup #846, but for debian:

Here is the list of main adaptations done in the specfile, which must be brought to deb packaging:

  • the dependencies are now explicitly listed in the RPM, including the bundled ones.
  • the configuration files are now in /etc/self-service-password directory
  • the previous configuration files present in /usr/share/self-service-password/conf (all .php files) are migrated to /etc/self-service-password/ during the upgrade process. config.inc.php is migrated as a config.inc.php.bak file, all other php file names are preserved.
  • the very old configuration files, present in /usr/share/self-service-password/ are NOT migrated during the upgrade process, and must be upgraded manually. These files have been deprecated since version 0.9, release in 2015 of October. The release note must define how to migrate these configuration files
  • smarty is now a required package See smarty4: Update to smarty4 #850
  • some bundled dependencies have been updated. See smarty4: Update to smarty4 #850, bootstrap 5.3: Update bootstrap library #834, and these dependency list: Update bundled php/javascript libs versions #849
  • unit tests are now run by the build process, only for fedora distribution and debian packaging
  • a minimum version of PHP is now required by the package: >=7.3
  • new basic dependency is now required by the package: sed
  • hidden files (.gitignore,...) from bundled dependencies are now removed from the package
  • now, the cache is being cleaned-up during self-service-password upgrade / install
@davidcoutadeur davidcoutadeur added this to the 1.6.0 milestone Mar 8, 2024
@davidcoutadeur davidcoutadeur self-assigned this Mar 8, 2024
davidcoutadeur pushed a commit that referenced this issue Mar 11, 2024
@davidcoutadeur
Copy link
Author

Done in #858

@davidcoutadeur
Copy link
Author

This feature should be ready. Only thing missing is updating the requirement of smarty4. It can be done in #850

@davidcoutadeur
Copy link
Author

TODO:

  • modify documentation (installation process)
  • add a release note in the documentation to describe the update process
  • require optionally smarty4 (preferred) or smarty3

davidcoutadeur pushed a commit that referenced this issue Mar 14, 2024
@davidcoutadeur
Copy link
Author

Last TODO should be ok with last commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant