Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwd_diff_last_min_chars is not evaluated the same way in backend and in frontend #868

Closed
davidcoutadeur opened this issue Mar 14, 2024 · 1 comment · Fixed by #869
Closed
Assignees
Labels
Milestone

Comments

@davidcoutadeur
Copy link

At frontend side, pwd_diff_last_min_chars means the number of characters that differs from old password, whatever the position of the character.

At backend side, pwd_diff_last_min_chars uses similar_text, which computes multiple patterns length found in the old password.

As pwd_diff_last_min_chars exists since more longer in self-service-password, it would be preferable to adapt js code. However, the similar_text function is not really standard...

@davidcoutadeur davidcoutadeur added this to the 1.6.0 milestone Mar 14, 2024
@davidcoutadeur davidcoutadeur self-assigned this Mar 14, 2024
@davidcoutadeur
Copy link
Author

davidcoutadeur commented Mar 14, 2024

Other problem:

at backend side, the password is only accepted when the number of "different characters" is strictly superior to pwd_diff_last_min_chars

This is not aligned with the documentation and also less logical:

You may also want to check for partial password reuses, ensuring the new password includes at least N distinct new characters:

$pwd_diff_last_min_chars = 3;

For example, for this configuration you must have at least N = 3 + 1 distinct new characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant