Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new ltb-ldap v0.2 #878

Closed
davidcoutadeur opened this issue Apr 3, 2024 · 3 comments · Fixed by #879 or #882
Closed

use new ltb-ldap v0.2 #878

davidcoutadeur opened this issue Apr 3, 2024 · 3 comments · Fixed by #879 or #882
Assignees
@davidcoutadeur
Labels
dependencies Pull requests that update a dependency file enhancement
Milestone
1.6.0

Comments

@davidcoutadeur
Copy link

Especially, we need to adapt the new method signature to avoid global variables.

See ltb-project/ltb-ldap#4
@davidcoutadeur davidcoutadeur added enhancement dependencies Pull requests that update a dependency file labels Apr 3, 2024
@davidcoutadeur davidcoutadeur added this to the 1.6.0 milestone Apr 3, 2024
@davidcoutadeur davidcoutadeur self-assigned this Apr 3, 2024
davidcoutadeur pushed a commit that referenced this issue Apr 3, 2024
use new ltb-ldap v0.2 and adapt method signatures (#878)
a79dcd1
@davidcoutadeur davidcoutadeur mentioned this issue Apr 3, 2024
Merged
davidcoutadeur pushed a commit that referenced this issue Apr 3, 2024
use temporary branch for testing new ltb-ldap feature (#878)
40eb35a
davidcoutadeur pushed a commit that referenced this issue Apr 3, 2024
adapt new function signatures from ltb-ldap 0.2.0 (#878)
c5fbf98
@davidcoutadeur
Copy link
Author

davidcoutadeur commented Apr 3, 2024 •
edited

Refactoring seems ready.

We will have to adapt the version of ltb-ldap (v0.2.0) in composer.json when released.

davidcoutadeur pushed a commit that referenced this issue Apr 3, 2024
use new ltb-ldap v0.2 and adapt method signatures (#878)
662d2b4
davidcoutadeur pushed a commit that referenced this issue Apr 3, 2024
@davidcoutadeur
use new ltb-ldap v0.2 and adapt method signatures (#878)
f9ace51
@davidcoutadeur davidcoutadeur reopened this Apr 3, 2024
@davidcoutadeur
Copy link
Author

Keeping this issue opened for the reminder:

We will have to adapt the version of ltb-ldap (v0.2.0) in composer.json when released.

davidcoutadeur pushed a commit that referenced this issue Apr 8, 2024
@markus-96
use new Ltb\Ldap functions (#878)
15c1543
davidcoutadeur pushed a commit that referenced this issue Apr 8, 2024
fix usage of new ltb-ldap functions (#878)
eff8db0
davidcoutadeur pushed a commit that referenced this issue Apr 8, 2024
fix call to non static methods (#878)
9bf4b7b 
must now be called on instance of Ldap class
@davidcoutadeur davidcoutadeur mentioned this issue Apr 8, 2024
Merged
davidcoutadeur pushed a commit that referenced this issue Apr 8, 2024
@markus-96 @davidcoutadeur
use new Ltb\Ldap functions (#878)
bf5939f
davidcoutadeur pushed a commit that referenced this issue Apr 8, 2024
@davidcoutadeur
fix usage of new ltb-ldap functions (#878)
003ccc9
davidcoutadeur pushed a commit that referenced this issue Apr 8, 2024
@davidcoutadeur
fix call to non static methods (#878)
1e55d52 
must now be called on instance of Ldap class
@davidcoutadeur davidcoutadeur reopened this Apr 8, 2024
davidcoutadeur pushed a commit that referenced this issue Apr 8, 2024
fix call to non static methods (#878)
6f2a07f
davidcoutadeur pushed a commit that referenced this issue Apr 24, 2024
use new ltb-ldap v0.2 (#878)
8031291
@davidcoutadeur
Copy link
Author

Version of ltb-ldap (v0.2.0) is now declared in in composer.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcoutadeur davidcoutadeur

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
1.6.0
1 participant
@davidcoutadeur