Output buffering to avoid failing session_start in PHP 7.1

[plewin]

Implements ob_start / ob_end_flush as discussed in #128

Revert "output_buffering" for php.ini because it is no longer needed.

Also remove redundant closing php tags to avoid outputing unintentionally white spaces

[coudot]

I don't understand why we need to remove all these closing tags, it is a little weird to have these PHP files with just an opening tag and no closing tag. Are you sure we can't do otherwise?

Does it not work if we simply add a close tag after ob_end_flush() in index.php?

[plewin]

It is a good practice (i agree, sometimes questionned), actually it is not necessary because I added the ob_start before the includes().

There is no problem if there is close tag after ob_end_flush() but it is the only file I'm okay with. Other files are better without the risk of unwanted whitespaces that may cause problems in future unit tests.

If a file is pure PHP code, it is preferable to omit the PHP closing tag at the end of the file. This prevents accidental whitespace or new lines being added after the PHP closing tag, which may cause unwanted effects because PHP will start output buffering when there is no intention from the programmer to send any output at that point in the script.
https://secure.php.net/manual/en/language.basic-syntax.phptags.php

[coudot]

Ok I did not know that!

I will merge this PR and close all issues related to 1.1. We can know release this version.

Thanks a lot for this work!