Quick search return with pattern like "foo*"

[nqb]

Hello,

At 2d51174, when doing a quick search with pattern like "foo*", White Pages just returns "entries found" message without results. Associated search filter (|(uid=*foo**)(cn=*foo**)(mail=*foo**))

White Pages should return same entries found with "foo" pattern.

[coudot]

Indeed this is a bug. If no entries found, the correct error message should be displayed.

[coudot]

Done. The test on error number was wrong.

[nqb]

At cfae137, message prints to the user when using pattern like "foo*" : "LDAP communication error".

To my mind, it's a "Bad search filter error". Could you override PHP LDAP error message to print a more friendly message like : "Forbidden pattern in search" ?

[nqb]

Currently, error message "LDAP communication error" leads users to believe a technical error on software. This implies bad reputation for White Pages. Search error message seems more accurate (i.e. Incorrect search : * not allowed).

[coudot]

I'm not sure that overriding PHP LDAP messages is a good idea, but it is maybe the only option. We should also see how to prevent user from doing an invalid search

[nqb]

#21

[coudot]

Fixed by #21