Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting and paging regression #72

Closed
ASLLR opened this issue Jul 17, 2019 · 8 comments
Closed

Sorting and paging regression #72

ASLLR opened this issue Jul 17, 2019 · 8 comments
Labels
Milestone

Comments

@ASLLR
Copy link

ASLLR commented Jul 17, 2019

Hi,
I'm always on my WP test version 0.3. I see a big change in tab repertory (or register). In WP 0.2 we have a search module who sort the result by page. We do not have in version 0.3 the arrow on top of the colum to sort also.

0.2 :
image

0.3 :
image

I doesn't see in documentation if it's a parameter to activate.

thank for all !

@coudot coudot added the bug label Jul 17, 2019
@coudot
Copy link
Member

coudot commented Jul 17, 2019

I was looking to the same issue, there is a probem with javascript code used for datatables:

SyntaxError: expected expression, got '&'

Do you have some php / smarty version change between 0.2 and 0.3? I am trying to understand what can cause this error.

@coudot
Copy link
Member

coudot commented Jul 17, 2019

The issue is in templates/footer.tpl:

{$datatables_page_length_choices|replace:'-1':($msg_pager_all|string_format:'"%s"') }

The quotes are put into HTML entities, and they should not.

You can override this by replacing the above expression by:

{$datatables_page_length_choices}

@coudot
Copy link
Member

coudot commented Jul 18, 2019

I am stuck on this issue, smarty is always converting quotes into HTML entites, which is not compatible with javascript code.

I think I will be forced to remove the label translation.

If everyone has an idea...

@coudot coudot added this to the 0.3 milestone Jul 18, 2019
@nqb
Copy link
Contributor

nqb commented Jul 18, 2019

Hello @coudot,

Maybe @proxyconcept can help us. He did the datatables integration in White Pages no ?

@coudot
Copy link
Member

coudot commented Jul 18, 2019

For now I have removed the replace with string_format. I will release like this if we don't find a better fix bfore 0.3 release.

@ASLLR
Copy link
Author

ASLLR commented Jul 18, 2019

i patch my file and the display like WP 0.2 is here. Nice.
but on drop down menu we have "-1" instead of "TOUT" and i think a space between users/groups menu and the drop down menu can be better.

@coudot
Copy link
Member

coudot commented Jul 22, 2019

I found the issue, it is beaucse of #58 : all printed strings are HTML escaped

I will see how to fix this.

@coudot coudot changed the title [WP 0.3] sorting and paging regression Sorting and paging regression Jul 22, 2019
@coudot
Copy link
Member

coudot commented Jul 22, 2019

Hello @ASLLR i found a fix, see a02d54f

I'm closing this issue, thanks for the report and the tests!

@coudot coudot closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants