-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a menu to display groups (based on groupofmember) #11
Conversation
@@ -7,7 +7,7 @@ | |||
# | |||
# This program is free software; you can redistribute it and/or | |||
# modify it under the terms of the GNU General Public License | |||
# as published by the Free Software Foundation; either version 2 | |||
# as published by the FreeSoftware Foundation; either version 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not needed
@@ -25,14 +25,20 @@ | |||
# LDAP | |||
$ldap_url = "ldap://localhost"; | |||
$ldap_starttls = false; | |||
$ldap_binddn = "cn=manager,dc=example,dc=com"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change default values
$ldap_bindpw = "secret"; | ||
$ldap_base = "dc=example,dc=com"; | ||
$ldap_user_base = "ou=users,".$ldap_base; | ||
$ldap_base = "dc=example"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change default values
# CSV | ||
$use_csv = true; | ||
$csv_filename = "white_pages_export_" . date("Y-m-d") . ".csv"; | ||
########################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not remove this
$vcard_file_extension = "vcf"; | ||
$vcard_file_identifier = "identifier"; | ||
$vcard_version = "4.0"; | ||
$vcard_map = array('FN' => 'fullname', 'N' => 'fullname', 'EMAIL' => 'mail', 'CATEGORIES' => 'businesscategory', 'ORG' => 'organization', 'ROLE' => 'employeetype', 'TEL;TYPE=work,voice;VALUE=uri:tel' => 'phone', 'TEL;TYPE=cell,voice;VALUE=uri:tel' => 'mobile', 'UID' => 'identifier'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not remove this
download_vcard_send_headers($vcard_file); | ||
echo print_vcard($entry[0], $attributes_map, $vcard_map, $vcard_version); | ||
die; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cancel this change
@@ -19,7 +19,7 @@ | |||
} | |||
closedir($handle); | |||
} | |||
$lang = detectLanguage($lang, $languages); | |||
#$lang = detectLanguage($lang, $languages); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cancel this change
$smarty->assign('date_specifiers',$date_specifiers); | ||
$smarty->assign('use_csv',$use_csv); | ||
$smarty->assign('use_vcard',$use_vcard); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cancel this change
@@ -1,55 +1,55 @@ | |||
<?php | |||
|
|||
#============================================================================== | |||
# English | |||
# French | |||
#============================================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this file for English translation
<input type="text" class="form-control" placeholder="{$msg_search}" name="search" value="{$search}" /> | ||
<span class="input-group-btn"> | ||
<button class="btn btn-default" type="submit"> <i class="fa fa-fw fa-search"></i></button> | ||
</span> | ||
</div> | ||
</form> | ||
{/if} | ||
{/if} | ||
{/if} | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you do this test in the menu
Thanks for the review Clément, I appreciate. It sounds that I didn't work on the last repo version: I'll check that in the next days. |
Do what you can, we maybe need to code this feature with more generic code anyway. We also need to apply the export to CSV action to this new kind of objects, this may be interesting. |
Thanks for the review Clément, I appreciate. It sounds that I didn't work on the last repo version: I'll check that in the next days. |
Alpha version.
This new menu permit to list groups and for each of them, the list of users that belong to it.
best