Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include group listing #12

Closed
wants to merge 8 commits into from

Conversation

olivierguillard
Copy link

This new menu allows to list user groups based on groupofnames and for each group to list the users that belong to it.

best

@coudot coudot self-requested a review January 15, 2018 06:09
@coudot coudot self-assigned this Jan 15, 2018
@coudot coudot added this to the 0.2 milestone Jan 15, 2018
@coudot coudot modified the milestones: 0.2, future Feb 4, 2018
@coudot
Copy link
Member

coudot commented Feb 4, 2018

Hello @olivierguillard, thanks a lot for this proposition. I don't think we can include it like that, as it involves a lot of code duplication. I will think about a better way to display/search any objects.

@olivierguillard
Copy link
Author

olivierguillard commented Feb 4, 2018 via email

@coudot
Copy link
Member

coudot commented Feb 5, 2018

There other objects like organizationalUnit or specific custom objects that can be interesting to display.

For posixGroup, you need to create a new type to be able to display the corresponding member entry. See also #20.

Anyway, your patch may indeed be useful for a lot of people, thanks!

@coudot
Copy link
Member

coudot commented Apr 13, 2018

Hello @olivierguillard, thanks again for taking time to contribute to the project.

I will not merge this pull request as I implemented it without creating separate pages. The feature will be available in 0.2 version.

@coudot coudot closed this Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants