Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in KSampler (inspire) after latest update? #100

Closed
alexopus opened this issue Apr 27, 2024 · 7 comments
Closed

Regression in KSampler (inspire) after latest update? #100

alexopus opened this issue Apr 27, 2024 · 7 comments

Comments

@alexopus
Copy link

alexopus commented Apr 27, 2024

There seems to be some sort of regression after 92cd510.

First Inspire sampler works fine, but when the result is forwarded to second, it goes crazy on the output.

Here is an example:
after

If I revert the above commit, it looks good again:
before

Recreating the node didn't help.

@LuLmaster69
Copy link

The same thing is happening during inpainting for me.

@josemerinom
Copy link

josemerinom commented Apr 27, 2024

update both Impact Pack and Inspire Pack

@alexopus
Copy link
Author

update both Impact Pack and Inspire Pack

Both are latest.

@LuLmaster69
Copy link

My results also have become non-deterministic. The previously used seeds give different results if you reload them in a new session of ComfyUI.
The default Ksampler in ComfyUI does not exhibit this behavior.

@ltdrdata
Copy link
Owner

I need to review it.
Sorry for the situation.

@wardensc2
Copy link

I also get the same result, I though denoise of Ksampler (inspire) is broken, somehow it's always is 1

@ltdrdata
Copy link
Owner

This is fixed. But update Impact Pack as well.
Impact Pack's sampler has a bug which is 3m is operate as 2m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants