Skip to content

Commit

Permalink
Fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ghiggi committed Nov 11, 2023
1 parent 74a7084 commit a3fe57e
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 28 deletions.
28 changes: 15 additions & 13 deletions disdrodb/tests/test_api/test_api_configs.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,18 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# -----------------------------------------------------------------------------.
"""Test DISDRODB configs."""
import os
import pytest
from disdrodb.api.configs import (
get_sensor_configs_dir,
read_config_file,
import os

import pytest

from disdrodb.api.configs import (
available_sensor_names,
)
get_sensor_configs_dir,
read_config_file,
)

def test_available_sensor_names():

def test_available_sensor_names():
assert len(available_sensor_names()) >= 3


Expand All @@ -34,12 +37,11 @@ def test_available_sensor_names():
def test_get_sensor_configs_dir(sensor_name, product):
config_sensor_dir = get_sensor_configs_dir(sensor_name=sensor_name, product=product)
assert os.path.isdir(config_sensor_dir)


def test_invalid_sensor_name():
with pytest.raises(ValueError):
get_sensor_configs_dir(sensor_name="NOT_EXIST", product="L0A")
get_sensor_configs_dir(sensor_name="NOT_EXIST", product="L0A")

with pytest.raises(ValueError):
read_config_file(sensor_name="OTT_Parsivel", product="L0A", filename="UNEXISTENT.yml")

read_config_file(sensor_name="OTT_Parsivel", product="L0A", filename="UNEXISTENT.yml")
11 changes: 5 additions & 6 deletions disdrodb/tests/test_api/test_create_directories.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,14 @@
_copy_station_metadata,
create_directory_structure,
create_initial_directory_structure,
create_metadata_directory,
create_issue_directory,
create_metadata_directory,
)
from disdrodb.api.path import (
define_campaign_dir,
define_metadata_dir,
define_metadata_filepath,
define_station_dir,
define_issue_dir,
)
from disdrodb.tests.conftest import create_fake_metadata_directory, create_fake_metadata_file, create_fake_raw_data_file
from disdrodb.utils.yaml import read_yaml
Expand Down Expand Up @@ -253,16 +252,16 @@ def test_create_directory_structure(tmp_path, mocker):
)
assert not os.path.exists(dst_product_file_filepath)
assert os.path.exists(dst_station_dir) and os.path.isdir(dst_station_dir)
# Test raise error if bad station_name

# Test raise error if bad station_name
with pytest.raises(ValueError):
create_directory_structure(
product=dst_product,
force=False,
processed_dir=processed_dir,
station_name="INEXISTENT_STATION",
)


def test_check_campaign_name_consistency(tmp_path):
base_dir = tmp_path / "DISDRODB"
Expand Down Expand Up @@ -375,4 +374,4 @@ def test_create_issue_directory(tmp_path):
data_source = "DATA_SOURCE"

issue_dir = create_issue_directory(base_dir, data_source=data_source, campaign_name=campaign_name)
assert os.path.isdir(issue_dir)
assert os.path.isdir(issue_dir)
16 changes: 7 additions & 9 deletions disdrodb/tests/test_metadata/test_metadata_imanipulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,21 @@


from disdrodb.metadata.manipulation import (
add_missing_metadata_keys,
remove_invalid_metadata_keys,
add_missing_metadata_keys,
)


def test_remove_invalid_metadata_keys():
metadata = {'data_source': 'valid', 'BLABLA': 'invalid'}
expected = {'data_source': 'valid'}
metadata = {"data_source": "valid", "BLABLA": "invalid"}
expected = {"data_source": "valid"}
result = remove_invalid_metadata_keys(metadata)
assert result == expected


def test_add_missing_metadata_keys():
# Test data
metadata = {'data_source': 'valid'}
metadata = {"data_source": "valid"}
result = add_missing_metadata_keys(metadata)
"valid" == result.pop("data_source")
len(set(result.values())) == 1 # ''



len(set(result.values())) == 1 # ''

0 comments on commit a3fe57e

Please sign in to comment.