Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EML 2.2 units? #30

Open
twhiteaker opened this issue Mar 27, 2019 · 7 comments
Open

EML 2.2 units? #30

twhiteaker opened this issue Mar 27, 2019 · 7 comments

Comments

@twhiteaker
Copy link
Contributor

According to EML Best Practices:

EDI has adopted the LTER Unit Registry and recommends that customUnit element be used for all units with content pulled from the Unit Registry, even when the unit is already listed in the standard unit dictionary.

So should all rows in EMLUnitDictionary have a custom value of false? Or maybe it's better if the R code uses for all units regardless of what the view says.

@gastil
Copy link
Contributor

gastil commented Mar 27, 2019

That decision is worth revisiting because Margaret overhauled the standard units in EML as part of EML2.2. In 2013 we chose to do only custom units partly because it was easier to code the EML generation to have just one way and not every unit is (was) offered as a standard unit. The Unit Dictionary itself was (and perhaps still is) not authoritative. Maybe EDI fixed this, but it used to be lots of bad-practice units were included.

@mobb
Copy link
Contributor

mobb commented Mar 27, 2019

that EML BP recommendation may be ... um ... misstated. IN MY DEFENSE, the doc did go out for review to 5 others. I hereby nominate @twhiteaker for the next go-round

@gastil
Copy link
Contributor

gastil commented Mar 27, 2019

Tim, just to be super clear, you do know the Unit Registry is a different thing than the Metabase table "EMLUnitDictionary", right? These are related, but different things.

@mobb
Copy link
Contributor

mobb commented Mar 27, 2019

agree that we might want to revisit (using simplified code). here is a link to the unit-registry work; those interested in where it should go next see the notes dir
https://github.com/EDIorg/unit-registry

@twhiteaker
Copy link
Contributor Author

@gastil I was aware of this one:
http://unit.lternet.edu/unitregistry/
which I presume EDI was in the processing was cleaning up at https://github.com/EDIorg/unit-registry.

And that is different from the EML unit dictionary. I assume but have not checked that the unit dictionary in metabase comes from the EML unit dictionary.

@twhiteaker
Copy link
Contributor Author

Speaking of best practice review, I did initiate a pull request for a markdown version of the BP back in August. I cleaned up some typos and XML along the way.

@atn38
Copy link
Member

atn38 commented Apr 26, 2019

To revisit this, maybe we'd like to core-mb to ship with the EML 2.2 UnitDictionary instead of the one we have now? @mob, are EML 2.2 units in table form somewhere?

@atn38 atn38 changed the title Change all units to custom units? EML 2.2 units? Apr 26, 2019
@atn38 atn38 added this to To do in Version 1 via automation Apr 26, 2019
@gastil gastil moved this from To do to Hold off until after v1 in Version 1 Jul 13, 2019
@atn38 atn38 added this to In progress in Version 2 Oct 4, 2019
@atn38 atn38 moved this from In progress to To do in Version 2 Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Version 1
  
Hold off until after v1
Version 2
  
To do
Development

No branches or pull requests

4 participants