-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EML 2.2 units? #30
Comments
That decision is worth revisiting because Margaret overhauled the standard units in EML as part of EML2.2. In 2013 we chose to do only custom units partly because it was easier to code the EML generation to have just one way and not every unit is (was) offered as a standard unit. The Unit Dictionary itself was (and perhaps still is) not authoritative. Maybe EDI fixed this, but it used to be lots of bad-practice units were included. |
that EML BP recommendation may be ... um ... misstated. IN MY DEFENSE, the doc did go out for review to 5 others. I hereby nominate @twhiteaker for the next go-round |
Tim, just to be super clear, you do know the Unit Registry is a different thing than the Metabase table "EMLUnitDictionary", right? These are related, but different things. |
agree that we might want to revisit (using simplified code). here is a link to the unit-registry work; those interested in where it should go next see the notes dir |
@gastil I was aware of this one: And that is different from the EML unit dictionary. I assume but have not checked that the unit dictionary in metabase comes from the EML unit dictionary. |
Speaking of best practice review, I did initiate a pull request for a markdown version of the BP back in August. I cleaned up some typos and XML along the way. |
To revisit this, maybe we'd like to core-mb to ship with the EML 2.2 UnitDictionary instead of the one we have now? @mob, are EML 2.2 units in table form somewhere? |
According to EML Best Practices:
So should all rows in EMLUnitDictionary have a
custom
value of false? Or maybe it's better if the R code uses for all units regardless of what the view says.The text was updated successfully, but these errors were encountered: