Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EMLUnitDictionary to UnitDictionary #31

Closed
twhiteaker opened this issue Mar 27, 2019 · 3 comments
Closed

Rename EMLUnitDictionary to UnitDictionary #31

twhiteaker opened this issue Mar 27, 2019 · 3 comments

Comments

@twhiteaker
Copy link
Contributor

You can add custom units to EMLUnitDictionary, so really it is a unit dictionary if you have added any custom units at all. And the custom attribute could be renamed to IsEmlUnit. See #30 .

@mobb
Copy link
Contributor

mobb commented Mar 27, 2019

you're right, that the list of units is a superset of what is included with EML schema (as is true for its parent, EMLUnitType). However, it has fields for STMML descriptions, which is the schema that EML uses, so the EML-moniker is appropriate (or could be STMML- instead).
This table (and EMLUnitType) will need to be revisited with EML 2.2, because there are some new unit features we may want to take advantage of. A name change (if deemed necessary) could happen then. changing a column name - would have to talk more about that.

related to https://github.com/EDIorg/unit-registry/
(which has notes about additions specifically to synchronize with EML 2.2)

@gastil
Copy link
Contributor

gastil commented Mar 27, 2019

It may be moot whether or not a unit listed in the metabase table EMLUnitDictionary is or is not also offered as a standard unit in EML2.1 or EML2.2, or any version. Looking at the way my table is populated, I have FALSE for the column "custom" for those units which are offered as a standardUnit in EML2.1. (What you suggested above is opposite boolean.) Notice that this depends on the version of EML. If I were designing this table today, I would name the column "standardInVersion" and list the EML version that has that unit as a standardUnit that I prefer to use, leaving it null or entering the word custom if either it is not offered as standard or I do not like how it is offered as standard.

@atn38
Copy link
Member

atn38 commented Jun 27, 2019

closing, EMLUnitDictionary is called the same in latest round of table renaming. See commit a477c52

@atn38 atn38 closed this as completed Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants