-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename EMLUnitDictionary to UnitDictionary #31
Comments
you're right, that the list of units is a superset of what is included with EML schema (as is true for its parent, EMLUnitType). However, it has fields for STMML descriptions, which is the schema that EML uses, so the EML-moniker is appropriate (or could be STMML- instead). related to https://github.com/EDIorg/unit-registry/ |
It may be moot whether or not a unit listed in the metabase table EMLUnitDictionary is or is not also offered as a standard unit in EML2.1 or EML2.2, or any version. Looking at the way my table is populated, I have FALSE for the column "custom" for those units which are offered as a standardUnit in EML2.1. (What you suggested above is opposite boolean.) Notice that this depends on the version of EML. If I were designing this table today, I would name the column "standardInVersion" and list the EML version that has that unit as a standardUnit that I prefer to use, leaving it null or entering the word custom if either it is not offered as standard or I do not like how it is offered as standard. |
closing, EMLUnitDictionary is called the same in latest round of table renaming. See commit a477c52 |
You can add custom units to EMLUnitDictionary, so really it is a unit dictionary if you have added any custom units at all. And the
custom
attribute could be renamed toIsEmlUnit
. See #30 .The text was updated successfully, but these errors were encountered: