Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up all error handling, remove panics #40

Merged
merged 15 commits into from
Sep 5, 2023
Merged

Conversation

lthoerner
Copy link
Owner

There seems to be little need for dynamic error handling in the project, and there are many areas in the code which still use .unwrap() and other panic-prone
code. This PR aims to fix both issues and provide a more easy-to-understand error API.

@lthoerner lthoerner marked this pull request as ready for review September 5, 2023 07:24
@lthoerner lthoerner merged commit ece35da into main Sep 5, 2023
1 check passed
@lthoerner
Copy link
Owner Author

This is mostly done - @doinkythederp will need to remove panic-prone calls in the plugins module when working on its implementation further, but I felt that it would be more relevant to a plugin feature PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants