New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search for also places that correspond to addr:street #115
Conversation
This is not specific to this code, developers should know how to use their tools.
Should be imported to Eclipse as a Makefile project, then all that should be implicit.
@johsin18 (CC @Nakaner ): Thank you for taking the time to write the pull request and sorry for the delayed answer. I started working on a file for Vagrant to resolve your mentioned
by providing a one-click solution to setup osmi-addresses. While preparing the Vagrantfile I discovered some issues with the GDAL version provided by Ubuntu 18.04 which I began to address here: https://github.com/ltog/osmi-addresses/commits/gdal_fix I'll be at SotM next weekend. If you'll be there too, we could meet. |
…ng arguments behind one's back.
This avoids converting back and forth.
This change * saves passing effectively unused arguments * avoids compiler warnings about unused arguments. * gets rid of a boolean argument acting more like an enum
So finally I was able to set up MapServer and test my changes on the map. Following the README, it was less hard than expected. I though I would have to also set up a server serving the base tile layers, but that's not needed, fortunately. So indeed my code was still buggy, but that should be fixed now. I would appreciate if you would merge my branch. |
@johsin18 : I'm glad the README was helpful... Recently I met with @Nakaner . We weren't sure if tying together Sorry, that this takes so long... |
Well, you had almost one year time to think about this, and now you change your minds :-( If you don't want this change, please merge at least my code cleanups, so that my work was not fully in vain. |
Thank you for your contribution. I decided to merge this pull request (not the refactoring only) because there are indeed cases where |
@Nakaner : Thank you for taking care of this! |
The Mapserver styles have been deployed now. |
Thanks for taking this in. |
This is a PR to solve issue #111.
All commits but the last are cleanup and refactoring.
I tested only using osmi-testzone.osm, and I ran it once on the Swiss data set. I was not able to test the results graphically (probably involves some huge setup).
Can somebody please test it graphically, e.g. the addresses around Tellplatz Basel should not be shown red anymore:
http://tools.geofabrik.de/osmi/?view=addresses&lon=7.59483&lat=47.54331&zoom=17&overlays=buildings,buildings_with_addresses,postal_code,entrances_deprecated,entrances,street_not_found,interpolation,interpolation_errors,connection_lines,nearest_points,nearest_roads,nearest_areas,addrx_on_nonclosed_way