Add test to as.fhx preventing output on bad input

ltrr-arizona-edu · Jul 24, 2019 · 440241e · 440241e
1 parent 6331ddf
commit 440241e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/R/utils.R b/R/utils.R
@@ -481,6 +481,10 @@ is.fhx <- function(x) {
 #'
 #' @export
 as.fhx <- function(x) {
+  if (!all(c("year", "series", "rec_type") %in% names(x))) {
+    stop("`x` must have members 'year', 'series', and 'rec_type'")
+  }
+
   yr <- as.numeric(x$year)
   series <- as.factor(x$series)
   record <- make_rec_type(x$rec_type)

diff --git a/tests/testthat/test-utils.R b/tests/testthat/test-utils.R
@@ -199,3 +199,17 @@ test_that("as.fhx works on list input", {
   expect_equal(new_fhx$series, factor(series_chr))
   expect_equal(new_fhx$rec_type, burnr::make_rec_type(events_chr))
 })
+
+test_that("as.fhx throws error when input missing key element", {
+  yrs <- c(1850, 2010)
+  series_chr <- c("a", "a")
+  events_chr <- c("pith_year", "bark_year")
+
+  test_df <- list(year = yrs,
+                  serie = series_chr,  # bad spelling
+                  rec_type = events_chr)
+
+  expect_error(burnr:::as.fhx(test_df), 
+               "`x` must have members 'year', 'series', and 'rec_type'")
+})
+