Add userspace namespace contexts to LTTng #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compudj
reviewed
Feb 18, 2019
liblttng-ust/lttng-context-vegid.c
Outdated
| static | ||
| gid_t get_vegid(void) | ||
| { | ||
| if (caa_unlikely(cached_vegid == (gid_t) -1)) { |
There was a problem hiding this comment.
I think load shared/store shared are missing here. And we should ideally return the value we read from getegid() through a local variable rather than re-read the static variable when we initialize it.
There was a problem hiding this comment.
same pattern applies to other contexts.
liblttng-ust/lttng-context-vegid.c
Outdated
| { | ||
| gid_t vegid; | ||
|
|
||
| vegid = get_vegid(); |
There was a problem hiding this comment.
could remove the local variable here.
There was a problem hiding this comment.
same applies to other contexts.
compudj
reviewed
Feb 18, 2019
liblttng-ust/ns.h
Outdated
|
|
||
| enum ns_ino_state { | ||
| NS_INO_UNAVAILABLE = 0x0, | ||
| NS_INO_UNPOPULATED = 0x1, |
There was a problem hiding this comment.
UNPOPULATED -> UNINITIALIZED ?
Add a context for each available kernel namespace which currently are : cgroup, ipc, mnt, net, pid, user and uts. The id chosen to identify the namespaces is the inode number of the file representing each one of them in the proc filesystem. This was introduced in kernel v3.8.0, if any of these context are enabled on a system running an older kernel, zero will be returned. Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Add a context for each available namespaced user and group IDs * vuid : real user ID * veuid : effective user ID * vsuid : saved set-user ID These are the IDs as seen in the current user namespace, see user_namespaces(7) and credentials(7) for details on each type. Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
|
Merged manually into lttng-ust master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.