Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sover detection for 0-based versioning #346

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Sep 30, 2023

Related to #345

With this patch applied Arch Linux generates this metadata (emphasis on Provides):

Name            : librustls
Version         : 0.11.0-1
Description     : Use rustls from languages other than Rust
Architecture    : x86_64
URL             : https://github.com/rustls/rustls-ffi
Licenses        : Apache-2.0  MIT
Groups          : None
Provides        : librustls.so=0.11-64

@lu-zero
Copy link
Owner

lu-zero commented Sep 30, 2023

Sounds good, thank you :)

@lu-zero lu-zero merged commit 775b396 into lu-zero:master Sep 30, 2023
14 checks passed
@kpcyrd kpcyrd deleted the zerover-sover branch October 1, 2023 07:34
@decathorpe
Copy link

FYI, introducing this change in a cargo-c patch release kind of "broke" builds of rav1e for Fedora Linux - I will need to patch rav1e to include the version_suffix_components=1 setting (and update cargo-c to the latest version) to maintain compatibility with older builds (which used .so.0), since changing the SONAME breaks installability of packages that dynamically link with rav1e (similar to the problem pointed out by the Arch maintainer). Changing the default behaviour here in a breaking way without bumping at least the "minor" release of cargo-c is kind of unexpected, at least to me.

@lu-zero
Copy link
Owner

lu-zero commented Dec 4, 2023

I'll prepare a new rav1e release soon and that will at least take care of it, thank you for the headsup.

I'll bump cargo-c as well soon. Sadly before this change (and the following) one may argue the previous situation might lead to subtly broken situations =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants