Skip to content

Commit

Permalink
Bug: luaL_tolstring may get confused with negative index
Browse files Browse the repository at this point in the history
When object has a '__name' metafield, 'luaL_tolstring' used the
received index after pushing a string on the stack.
  • Loading branch information
roberto-ieru committed Jul 22, 2021
1 parent 62fb934 commit 439e45a
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 0 deletions.
1 change: 1 addition & 0 deletions lauxlib.c
Original file line number Diff line number Diff line change
Expand Up @@ -881,6 +881,7 @@ LUALIB_API lua_Integer luaL_len (lua_State *L, int idx) {


LUALIB_API const char *luaL_tolstring (lua_State *L, int idx, size_t *len) {
idx = lua_absindex(L,idx);
if (luaL_callmeta(L, idx, "__tostring")) { /* metafield? */
if (!lua_isstring(L, -1))
luaL_error(L, "'__tostring' must return a string");
Expand Down
3 changes: 3 additions & 0 deletions ltests.c
Original file line number Diff line number Diff line change
Expand Up @@ -1743,6 +1743,9 @@ static struct X { int x; } x;
(void)s1; /* to avoid warnings */
lua_longassert((s == NULL && s1 == NULL) || strcmp(s, s1) == 0);
}
else if EQ("Ltolstring") {
luaL_tolstring(L1, getindex, NULL);
}
else if EQ("type") {
lua_pushstring(L1, luaL_typename(L1, getnum));
}
Expand Down
16 changes: 16 additions & 0 deletions testes/errors.lua
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,22 @@ do -- named objects (field '__name')
checkmessage("return {} < XX", "table with My Type")
checkmessage("return XX < io.stdin", "My Type with FILE*")
_G.XX = nil

if T then -- extra tests for 'luaL_tolstring'
-- bug in 5.4.3; 'luaL_tolstring' with negative indices
local x = setmetatable({}, {__name="TABLE"})
assert(T.testC("Ltolstring -1; return 1", x) == tostring(x))

local a, b = T.testC("pushint 10; Ltolstring -2; return 2", x)
assert(a == 10 and b == tostring(x))

setmetatable(x, {__tostring=function (o)
assert(o == x)
return "ABC"
end})
a, b, c = T.testC("pushint 10; Ltolstring -2; return 3", x)
assert(a == x and b == 10 and c == "ABC")
end
end

-- global functions
Expand Down

0 comments on commit 439e45a

Please sign in to comment.