Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php7.1; tests; travis #77

Merged
merged 10 commits into from
Feb 9, 2020
Merged

php7.1; tests; travis #77

merged 10 commits into from
Feb 9, 2020

Conversation

gam6itko
Copy link
Collaborator

@gam6itko gam6itko commented Feb 5, 2020 •
edited
Loading

To solve project issues and merge PRs we need to have small bunch of tests.

Changes:

  • up composer php verison to 7.1
  • add phpunit dev dependency
  • add travis.yaml to run tests
  • small bunch of tests with SimpleTests.php

Added:

  • Table::pickRecord method allows to get record by index

Fixed:

@gam6itko
Copy link
Collaborator Author

gam6itko commented Feb 5, 2020

@luads Can you review and approve this PR. I'm going to solve project issues soon and release v1.1

@gam6itko gam6itko requested a review from luads February 5, 2020 11:59
@gam6itko gam6itko merged commit df7332d into luads:master Feb 9, 2020
@gam6itko gam6itko mentioned this pull request Feb 9, 2020
Closed
@gam6itko
Copy link
Collaborator Author

gam6itko commented Feb 9, 2020

@luads You need to enable travis CI for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luads luads Awaiting requested review from luads

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gam6itko