Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work after github removed git:// support #61

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

kozak
Copy link
Contributor

@kozak kozak commented Nov 2, 2021

@Totktonada
Copy link
Member

Thanks! Please, squash intermediate commits and link GitHub's announcement in the commit message.

@kozak
Copy link
Contributor Author

kozak commented Nov 3, 2021

Done

@Totktonada
Copy link
Member

Cannot update the branch myself. Sorry for nitpicking, but, please, move the URL from the commit title and follow 50/72 rule. Like so:

rockspec: use git+https:// for git repository URL

Due to [1] the rockspec no longer works.

[1]: https://github.blog/2021-09-01-improving-git-protocol-security-github/

@kozak
Copy link
Contributor Author

kozak commented Nov 9, 2021

done

@Totktonada
Copy link
Member

Nice, thanks!

@Totktonada Totktonada requested a review from a team November 21, 2021 13:30
@ligurio ligurio self-requested a review November 22, 2021 07:32
@Totktonada Totktonada merged commit 56316aa into luafun:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants