Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install missing dependencies for tests.yml #1076

Merged
merged 1 commit into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,16 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Install depenencies
run: |
sudo apt-get update
sudo apt-get install luajit libluajit-5.1-dev libjavascriptcoregtk-4.0-dev libwebkit2gtk-4.1-dev libgtk-3-dev libglib2.0-dev luarocks
- name: Install lua dependencies
run: |
sudo luarocks --lua-version 5.1 install luafilesystem
sudo luarocks --lua-version 5.1 install luassert
sudo luarocks --lua-version 5.1 install luacheck
Comment on lines +22 to +24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why from luarocks and not via apt? lua-check lua-luassert lua-filesystem are available for lua 5.1 and my debian machine here. So I assume they are available here too. Or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the reason is that I simply forgot about that possibility :) sent #1077

- name: make
run: make
- name: make run-tests
run: make run-tests
2 changes: 1 addition & 1 deletion clib/unique.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ luaH_unique_new(lua_State *L)

GError *error = NULL;
if (!globalconf.application) {
#if GTK_CHECK_VERSION(2,74,0)
#if GLIB_CHECK_VERSION(2,74,0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR, but good catch.

globalconf.application = gtk_application_new(name, G_APPLICATION_DEFAULT_FLAGS);
#else
globalconf.application = gtk_application_new(name, G_APPLICATION_FLAGS_NONE);
Expand Down