Sync to upstream/release/564 (#841)

This week we only have updates to new type solver and JIT. Both projects
are still in the process of being built out. Neither are ready for
general use yet.

In the new solver, we fixed issues with recursive type aliases.
Duplicated type parameters are once again reported, exported types are
being recorder and function argument names are placed inside function
types.
We also made improvements to restore parts of bidirectional type
tracking.

On native code generation side, namecall instruction lowering was fixed,
we fixed inconsistencies in IR command definitions and added utility
function to help with constant folding.

Analysis/include/Luau/Constraint.h

@@ -90,6 +90,8 @@ struct NameConstraint
     TypeId namedType;
     std::string name;
     bool synthetic = false;
+    std::vector<TypeId> typeParameters;
+    std::vector<TypePackId> typePackParameters;
 };
 
 // target ~ inst target
@@ -101,7 +103,6 @@ struct TypeAliasExpansionConstraint
 
 struct FunctionCallConstraint
 {
-    std::vector<NotNull<const struct Constraint>> innerConstraints;
     TypeId fn;
     TypePackId argsPack;
     TypePackId result;

Analysis/include/Luau/ConstraintGraphBuilder.h

@@ -162,10 +162,10 @@ struct ConstraintGraphBuilder
     void visit(const ScopePtr& scope, AstStatDeclareFunction* declareFunction);
     void visit(const ScopePtr& scope, AstStatError* error);
 
-    InferencePack checkPack(const ScopePtr& scope, AstArray<AstExpr*> exprs, const std::vector<TypeId>& expectedTypes = {});
-    InferencePack checkPack(const ScopePtr& scope, AstExpr* expr, const std::vector<TypeId>& expectedTypes = {});
+    InferencePack checkPack(const ScopePtr& scope, AstArray<AstExpr*> exprs, const std::vector<std::optional<TypeId>>& expectedTypes = {});
+    InferencePack checkPack(const ScopePtr& scope, AstExpr* expr, const std::vector<std::optional<TypeId>>& expectedTypes = {});
 
-    InferencePack checkPack(const ScopePtr& scope, AstExprCall* call, const std::vector<TypeId>& expectedTypes);
+    InferencePack checkPack(const ScopePtr& scope, AstExprCall* call);
 
     /**
      * Checks an expression that is expected to evaluate to one type.
@@ -244,8 +244,10 @@ struct ConstraintGraphBuilder
      **/
     TypePackId resolveTypePack(const ScopePtr& scope, const AstTypeList& list, bool inTypeArguments);
 
-    std::vector<std::pair<Name, GenericTypeDefinition>> createGenerics(const ScopePtr& scope, AstArray<AstGenericType> generics);
-    std::vector<std::pair<Name, GenericTypePackDefinition>> createGenericPacks(const ScopePtr& scope, AstArray<AstGenericTypePack> packs);
+    std::vector<std::pair<Name, GenericTypeDefinition>> createGenerics(
+        const ScopePtr& scope, AstArray<AstGenericType> generics, bool useCache = false);
+    std::vector<std::pair<Name, GenericTypePackDefinition>> createGenericPacks(
+        const ScopePtr& scope, AstArray<AstGenericTypePack> packs, bool useCache = false);
 
     Inference flattenPack(const ScopePtr& scope, Location location, InferencePack pack);
 

Analysis/include/Luau/ConstraintSolver.h

@@ -183,7 +183,7 @@ struct ConstraintSolver
     /** Pushes a new solver constraint to the solver.
      * @param cv the body of the constraint.
      **/
-    void pushConstraint(NotNull<Scope> scope, const Location& location, ConstraintV cv);
+    NotNull<Constraint> pushConstraint(NotNull<Scope> scope, const Location& location, ConstraintV cv);
 
     /**
      * Attempts to resolve a module from its module information. Returns the

Analysis/include/Luau/Frontend.h

@@ -162,7 +162,7 @@ struct Frontend
     ScopePtr getGlobalScope();
 
 private:
-    ModulePtr check(const SourceModule& sourceModule, Mode mode, const ScopePtr& environmentScope, std::vector<RequireCycle> requireCycles,
+    ModulePtr check(const SourceModule& sourceModule, Mode mode, std::vector<RequireCycle> requireCycles,
         bool forAutocomplete = false);
 
     std::pair<SourceNode*, SourceModule*> getSourceNode(const ModuleName& name);
@@ -202,4 +202,16 @@ struct Frontend
     ScopePtr globalScope;
 };
 
+ModulePtr check(
+    const SourceModule& sourceModule,
+    const std::vector<RequireCycle>& requireCycles,
+    NotNull<BuiltinTypes> builtinTypes,
+    NotNull<InternalErrorReporter> iceHandler,
+    NotNull<ModuleResolver> moduleResolver,
+    NotNull<FileResolver> fileResolver,
+    const ScopePtr& globalScope,
+    NotNull<UnifierSharedState> unifierState,
+    FrontendOptions options
+);
+
 } // namespace Luau

Analysis/src/Autocomplete.cpp

@@ -16,7 +16,6 @@
 LUAU_FASTFLAGVARIABLE(LuauCompleteTableKeysBetter, false);
 LUAU_FASTFLAGVARIABLE(LuauFixAutocompleteInWhile, false);
 LUAU_FASTFLAGVARIABLE(LuauFixAutocompleteInFor, false);
-LUAU_FASTFLAGVARIABLE(LuauAutocompleteStringContent, false);
 
 static const std::unordered_set<std::string> kStatementStartingKeywords = {
     "while", "if", "local", "repeat", "function", "do", "for", "return", "break", "continue", "type", "export"};
@@ -1268,9 +1267,6 @@ static bool isSimpleInterpolatedString(const AstNode* node)
 
 static std::optional<std::string> getStringContents(const AstNode* node)
 {
-    if (!FFlag::LuauAutocompleteStringContent)
-        return std::nullopt;
-
     if (const AstExprConstantString* string = node->as<AstExprConstantString>())
     {
         return std::string(string->value.data, string->value.size);

Analysis/src/BuiltinDefinitions.cpp

@@ -15,8 +15,6 @@
 
 #include <algorithm>
 
-LUAU_FASTFLAGVARIABLE(LuauBuiltInMetatableNoBadSynthetic, false)
-
 /** FIXME: Many of these type definitions are not quite completely accurate.
  *
  * Some of them require richer generics than we have.  For instance, we do not yet have a way to talk
@@ -558,8 +556,6 @@ static std::optional<WithPredicate<TypePackId>> magicFunctionSetMetaTable(
 
                 if (tableName == metatableName)
                     mtv.syntheticName = tableName;
-                else if (!FFlag::LuauBuiltInMetatableNoBadSynthetic)
-                    mtv.syntheticName = "{ @metatable: " + metatableName + ", " + tableName + " }";
             }
 
             TypeId mtTy = arena.addType(mtv);