Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass string content to autocomplete callback #800

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Pass string content to autocomplete callback #800

merged 2 commits into from
Jan 11, 2023

Conversation

JohnnyMorganz
Copy link
Contributor

@JohnnyMorganz JohnnyMorganz commented Jan 10, 2023 •
edited
Loading

Closes #718

We pass an extra contents parameter to the string callback function to provide contextual information for autocomplete.

Because we support both string literals and simple interpolated strings, we pass it through as a std::string value.

This is a breaking change

@vegorov-rbx vegorov-rbx merged commit 8649491 into luau-lang:master Jan 11, 2023
@JohnnyMorganz JohnnyMorganz deleted the string-completion branch January 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegorov-rbx vegorov-rbx vegorov-rbx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass current string contents to StringCompletionCallback
2 participants
@JohnnyMorganz @vegorov-rbx