Fix grammar issues #915
Merged
Fix grammar issues #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type list for function declarations does not accept defaults, but the grammar incorrectly allowed this
vegorov-rbx
approved these changes
May 2, 2023
JohnnyMorganz
changed the title
JohnnyMorganz
commented
May 2, 2023
JohnnyMorganz
changed the title
JohnnyMorganz
commented
May 2, 2023
docs/_pages/grammar.md
Outdated
Comment on lines
78
to
79
| GenericTypePackParameterWithDefault = NAME '...' ['=' (TypePack | VariadicTypePack | GenericTypePack)] | ||
| GenericTypeListWithDefaults = NAME ['=' Type] [',' GenericTypeListWithDefaults] | GenericTypePackParameterWithDefault {',' GenericTypePackParameterWithDefault} |
There was a problem hiding this comment.
I think this is still actually slightly wrong. It does not encode that after one generic is specified with a default, then all other generics must also have a default. It currently allows something like <X = string, Y, Z... = ...string, P...>.
Something like the following may be better:
Suggested change
| GenericTypePackParameterWithDefault = NAME '...' ['=' (TypePack | VariadicTypePack | GenericTypePack)] | |
| GenericTypeListWithDefaults = NAME ['=' Type] [',' GenericTypeListWithDefaults] | GenericTypePackParameterWithDefault {',' GenericTypePackParameterWithDefault} | |
| GenericTypePackParameterWithDefault = NAME '...' '=' (TypePack | VariadicTypePack | GenericTypePack) | |
| GenericTypeListWithDefaults = | |
| GenericTypeList | | |
| NAME {',' NAME} {',' NAME '=' Type} {',' GenericTypePackParameterWithDefault} | | |
| NAME '=' Type {',' GenericTypePackParameterWithDefault} | | |
| GenericTypePackParameterWithDefault {',' GenericTypePackParameterWithDefault} |
But is it the simplest it can be? I think it covers everything
vegorov-rbx
reviewed
May 4, 2023
Co-authored-by: vegorov-rbx <75688451+vegorov-rbx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{}string??,(string),(string | number) & boolean)