-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024.1.0: Advanced Boot Logo #191
2024.1.0: Advanced Boot Logo #191
Conversation
Hi, also a nice addition. I will add it to the readme before releasing. |
Co-authored-by: chertvl <38353584+chertvl@users.noreply.github.com>
9502ca4
to
6210dde
Compare
You don |
I also think boot_mode 0 should be default e.g. the normal pure display and from 1 to to 4 should be your animations |
I didn't quite understand the question. If |
I don’t see the point, if we indicate in the configuration that we want the default logo (mode 0 you suggested), then what difference does it make to change the mode or comment out any line from |
On a fresh installation of 2024.1.0-prerelease there is no on_start_running:
id(rgb32x8)->bitmap_screen(..... way of showing a "boot-logo". The visual result is the same as your method. Now you reintroduced the boot_logo and your part is working, but somehow our code base drifted. Just try the version 2024.1.0-prerelease in the repo and you will see. |
This is not quite true if you don't turn on
The startup process will be like this:
If you enable
|
I tested this feature and liked it. code and video: https://drive.google.com/file/d/1GGKvRePjlyhDy6QFaLkTMfeWjZEa8yZG/view?usp=sharing |
I see, I was a little wrong. But still, I think it would be clearer to have: if 0 - Display boot_logo without filter and mask, just colorful The |
Yes it is |
Well now it is, to enable this mode it is necessary to write Look: |
But we can do it just in the base, without any advanced keys, based on the mode and the presence of the logo. I just decided not to overload not all the necessary functionality. |
@lubeda I think I get your idea, sorry I didn't get it right away. You suggest to remove |
Advanced mode of boot logo display
Allows you to show a custom boot logo instead of the default animation when booting.
advanced_boot
(optional, boolean, only on ESP32, Default: false) Enables advanced mode of boot logo display.boot_logo
(optional, string, only on ESP32): Mask defined as rgb565 array used to display boot logo, color is completely ignored, output depends on boot logo display mode.boot_mode
(optional, integer, only on ESP32, Default: 3) Mode of displaying boot logo, can take value from 0 to 3:Mode 3 is best used with the option
After startup, to save memory, you can clear the array with the boot logo by calling the boot_logo setup function with an empty parameter.
But in case time is lost (unsynchronization), the standard animation will be shown.
PS: I see the readme is constantly being updated, so I decided not to add this text to the file itself. I will leave the text of changes here.