-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "2024.1.0: Advanced clock - draw date"" #199
Revert "Revert "2024.1.0: Advanced clock - draw date"" #199
Conversation
But when I try to make a PR with such a configuration file, I get an error. https://github.com/lubeda/EspHoMaTriXv2/actions/runs/7501946835/job/20423611396 |
I did an experiment in my repository, made a similar PR (Revert, Revert) accepted it in 2024.1.0, |
If we want to make |
Is If it's not breaking, fine, and perhaps this could lead to a little code clean up. e.g. Sorry, I'm low on spare time. |
No, everything should work as before without problems.
When calling
When this mode is enabled, everything should continue to work as before, i.e. There should be no changes in the rendering or filling of regular methods. But we can leave this mode disabled by default (as it is now). And then any user will be able to read the documentation, enable it and customize it to their taste. |
It's okay, I use this mode every day, so far there have not been a single error or incorrect operation. And we are in no hurry, unless of course there are plans to release the 2024.1.0 release right now. |
Reverts #198
Are you sure you haven't forgotten about advanced_clock: true ?