Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically add additional roles #36

Merged
merged 8 commits into from
Oct 11, 2022
Merged

Automatically add additional roles #36

merged 8 commits into from
Oct 11, 2022

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Oct 11, 2022

Closes #34

lubianat
lubianat reviewed Oct 11, 2022
View reviewed changes
Copy link
Owner

@lubianat lubianat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Didn't know about dedent, useful stuff.

@lubianat lubianat merged commit a204e19 into master Oct 11, 2022
@lubianat lubianat deleted the add-degree-synonyms branch October 11, 2022 13:37
@cthoyt
Copy link
Collaborator Author

cthoyt commented Oct 11, 2022

@lubianat we could also reuse this code to other base wikidata identifiers like Q66666685 for "academic professional"

@cthoyt cthoyt mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubianat lubianat lubianat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-populate degree dictionary
2 participants
@cthoyt @lubianat