Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords as "field of work" statements #38

Closed
lubianat opened this issue Oct 11, 2022 · 8 comments · Fixed by #48
Closed

Add keywords as "field of work" statements #38

lubianat opened this issue Oct 11, 2022 · 8 comments · Fixed by #48
Assignees
Labels
enhancement New feature or request

Comments

@lubianat
Copy link
Owner

e.g https://orcid.org/0000-0002-6049-9865

@jvfe
Copy link
Collaborator

jvfe commented Oct 11, 2022

I'll try working on this

@jvfe jvfe added the enhancement New feature or request label Oct 11, 2022
@cthoyt
Copy link
Collaborator

cthoyt commented Oct 11, 2022

@jvfe maybe you can also use a similar concept as in #36 to identify a high-level wikidata term that most fields of work / topics are a subclass of, and then we can automatically pull them down and pre-populate a dictionary.

@jvfe
Copy link
Collaborator

jvfe commented Oct 11, 2022

Sounds like a good idea. The same logic in #36 would probably work for this, would just have to change Q189533 (academic degree) for something like Q11862829 (academic discipline).

I'll try it out, thanks!

@cthoyt
Copy link
Collaborator

cthoyt commented Oct 11, 2022

@jvfe I just generalized the code from #36 in 990e7e4 so you can easily reuse it.

@lubianat
Copy link
Owner Author

It is a good idea, we just need to watch out for duplicates. They are already abundant in https://github.com/lubianat/pyorcidator/blob/master/src/pyorcidator/dictionaries/role.json with no easy fix.

@lubianat
Copy link
Owner Author

I'd rather actually leave it to manual curation until we get a better sense of the diversity.
Automatically adding topics now might add a lot of silent false positives.

@jvfe jvfe self-assigned this Oct 13, 2022
@lubianat
Copy link
Owner Author

@jvfe are you working on that? I'll start a branch on my own (kind of wan't some hack on this today), but I won't merge anything

jvfe added a commit that referenced this issue Oct 14, 2022
- Create process_keyword_entries to process keywords when available
- Create fields.json to curate fields of work

- Closes #38
jvfe added a commit that referenced this issue Oct 14, 2022
- Create process_keyword_entries to process keywords when available
- Create fields.json to curate fields of work

- Closes #38
@jvfe
Copy link
Collaborator

jvfe commented Oct 14, 2022

@jvfe are you working on that? I'll start a branch on my own (kind of wan't some hack on this today), but I won't merge anything

Check #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants