Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement data model for quickstatements #39

Closed
cthoyt opened this issue Oct 11, 2022 · 3 comments · Fixed by #41
Closed

Implement data model for quickstatements #39

cthoyt opened this issue Oct 11, 2022 · 3 comments · Fixed by #41

Comments

@cthoyt
Copy link
Collaborator

cthoyt commented Oct 11, 2022

Right now, the construction of the quickstatements text is really hard to understand, and therefore to debug or extend. I would suggest creating a data model (i.e., a set of interconnected classes) that can better assist with the construction of quickstatements in a programmatic way, then can also implement serialization to text

@lubianat
Copy link
Owner

I think having a simple quickstatements data model is great, and it eventually deserves a module on its own!

I'd definitely incorporate it in https://github.com/lubianat/wdcuration

@cthoyt
Copy link
Collaborator Author

cthoyt commented Oct 12, 2022

@lubianat I don't think so - wdcuration needs a lot of work. I would rather spin it out myself later and ensure maximum code quality and testing and to make sure that it can be relatively stable. It's sort of problematic to have to edit wdcuration functionality when trying to get pyorcidator to work

@lubianat
Copy link
Owner

yes, that is what I mean, incorporate by import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants