Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Add start and end time as qualifiers (and not references) #46

Closed
lubianat opened this issue Oct 14, 2022 · 0 comments · Fixed by #47
Closed

BUG Add start and end time as qualifiers (and not references) #46

lubianat opened this issue Oct 14, 2022 · 0 comments · Fixed by #47
Labels
bug Something isn't working

Comments

@lubianat
Copy link
Owner

@cthoyt @jvfe bug on the approved code and tests. Start and end times need to be qualifiers, not refs.
@jvfe jvfe added the bug Something isn't working label Oct 14, 2022
lubianat added a commit that referenced this issue Oct 14, 2022
@lubianat
hotfix: Set times as qualifiers
f264611 
They were currently being added as references.
Closes #46.
@jvfe jvfe linked a pull request Oct 14, 2022 that will close this issue
hotfix: Set times as qualifiers in quickstatements #47
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hotfix: Set times as qualifiers in quickstatements lubianat/pyorcidator
2 participants
@lubianat @jvfe