Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid code repetition among import and import_list #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Apr 13, 2022

  1. refactor: Unite orcid list & single orcid function

    - Instead of repeating code between import info from list and import
      info, include a type guard on import_info to check if the argument
    provided is a path or a just a string.
    
    - Addresses lubianat#14
    jvfe committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    ffd5814 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. refactor: Keep 2 commands but reduce repetition

    - Keeps both commands, but refactors repeated functionality into a
      separate function.
    - Also improves the way the path to the ORCID file is read
    - Also adds missing open_browser to import_list
    
    - Closes lubianat#14
    jvfe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    84142c8 View commit details
    Browse the repository at this point in the history
  2. refactor: Move open-browser to click group

    - This way the same option code isn't repeated between modules, it's
      merely passed down as context
    - Open browser can now be called as:
    `pyorcidator --open-browser import --orcid ORCID_ID`
    jvfe committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    e5e8285 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Configuration menu
    Copy the full SHA
    8f98cd6 View commit details
    Browse the repository at this point in the history