Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add black check to the CI #45

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add black check to the CI #45

wants to merge 3 commits into from

Conversation

jvfe
Copy link
Collaborator

@jvfe jvfe commented Oct 13, 2022

  • style: Reformat helper module with black
  • style: Reformat tests
  • ci: Add black check to CI

@jvfe
style: Reformat helper module with black
d6b435f
@jvfe
style: Reformat tests
9055b4f
@jvfe
ci: Add black check to CI
715ea64 
- Always check in PRs/Push if the code is properly formatted
  with black.

- Closes #44
@jvfe jvfe linked an issue Oct 13, 2022 that may be closed by this pull request
Include black in the CI #44
Open
@cthoyt
Copy link
Collaborator

cthoyt commented Oct 13, 2022

I totally agree with the idea but I disagree with the implementation. Having the check run inside CI in a way that’s not reproducibly locally means that passing CI is a moving target. Running black checking with something like flake8 and wrapping it with Tox is much better. I will demonstrate soon

@lubianat
Copy link
Owner

Nice idea, and discussion. Maybe we can do a live code dojo someday and work on some of this stuff?

@jvfe jvfe marked this pull request as draft October 14, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include black in the CI
3 participants
@jvfe @cthoyt @lubianat