-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runaway filedescriptors #141
Comments
Thanks for the report. Yes we are indeed leaking this FD: Line 101 in 7617bf7
The proper fix would be to enhance the A quicker fix in this crate instead would be to manually call If you want to provide some patch to tackle this, I'll be happy to review. |
Why do we even use |
In any case I think we should generally make use of I'd be in favour of this bump and the corresponding change; if you agree @lucab I'd make a corresponding PR. |
@swsnr I think I switched some other parts of this function to use |
Unlike the nix API the std type has clear ownership semantics and thus takes care to close the socket again. Previously we leaked an FD here. Fixes #141
Thank you for the quick fix! |
I have the following patch I just applied to switch to
systemd
crate. I was indifferent to the two until I noticed that my file descriptor count was going up on every tick here. I'm sure I have done something foolish in my implementation since nobody else has reported it but I also wanted to share in case it was useful to you or someone else. Happy to provide any further details if it's useful.I did like that your crate expressed the enums and didn't require libsystemd, it made my deployment a little less complicated and the code easier to read. Thank you for your work here!
The text was updated successfully, but these errors were encountered: