check for mips targets for stat.st_dev definitions #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
reviewed
Jan 26, 2022
|
Thanks for the PR. Can you maybe add some details about where this showed up? |
|
I'd also appreciate a summary of the linked bug report; it's rather long, and I'm not sure what information or fact I should read from it. |
st_dev has wrong type in glibc when using mips/O32 ABI its type should be dev_t but it is set to unsigned long int this is specific issue on mips/o32 ABI in glibc for details See https://sourceware.org/bugzilla/show_bug.cgi?id=17786 currently the build fails on mips archirecture with type mismatches Fixes error[E0308]: mismatched types * --> /usr/src/debug/python3-pyruvate/1.1.2-r0/cargo_home/bitbake/libsystemd-0.4.1/src/logging.rs:296:25 | 296 | device: stat.st_dev, | ^^^^^^^^^^^ expected `u64`, found `u32` Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
What Rust tier does the corresponding target belong to? I'm asking because I'm not keen on maintaining architecture specific code here. If it's anything but a tier 1 target my vote would be to account for this mismatch for elsewhere, e.g. upstream libc or nix😬 I'm fine with using a different API at this place, as long as we don't have do deal with cfg here. Perhaps we can use std::fs::Metadata here somehow. |
|
I'm closing this in favour of #104 which I just merged 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
https://sourceware.org/bugzilla/show_bug.cgi?id=17786
Signed-off-by: Khem Raj raj.khem@gmail.com