Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activation: fix build for compatibility with nix 0.24 #108

Merged
merged 1 commit into from
Feb 28, 2022
Merged

activation: fix build for compatibility with nix 0.24 #108

merged 1 commit into from
Feb 28, 2022

Conversation

skrap
Copy link
Contributor

@skrap skrap commented Feb 24, 2022 •
edited
Loading

See #107.

This should be compatible with existing code as well, as it just does what nix used to do. I don't see any way to check a FD in this way without unsafe, unfortunately!

@skrap skrap mentioned this pull request Feb 24, 2022
Closed
@lucab
Copy link
Owner

lucab commented Feb 28, 2022

Thanks for the PR!
I'd be happier having no usafe involved in this, but I looked around and I think the new nix API does not really support our usecase anymore. I left a note at nix-rust/nix#1639 (comment) asking about that.
In the meanwhile, I'm happy to merge this PR and possibly later re-adjust for a new safe API.

@lucab lucab changed the title fix build for compatibility with nix 0.24 activation: fix build for compatibility with nix 0.24 Feb 28, 2022
@lucab lucab merged commit 92bdd05 into lucab:master Feb 28, 2022
@skrap
Copy link
Contributor Author

skrap commented Feb 28, 2022

Thanks! And thanks for this crate! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucab lucab lucab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skrap @lucab