daemon/notify: sanity check state entries #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janderholm could you please have a look at this new logic? |
lucab
force-pushed
the
ups/daemon-notify-validate-fdname
branch
from
3a0451a
to
6fc1e4c
Compare
|
@swsnr this one is now ready for review. |
swsnr
reviewed
Dec 14, 2022
This performs some basic sanity checks against notify-state entries. Notably, it checks length and content of `FDNAME` labels.
lucab
force-pushed
the
ups/daemon-notify-validate-fdname
branch
from
6fc1e4c
to
cc8b31c
Compare
swsnr
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs some basic sanity checks against notify-state entries.
Notably, it checks lenght and content of
FDNAMElabels.Closes: #116