New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing modf files with the gray filter #710
Comments
You are right. I only created the arf and mrf files for the gray filter, not the modf. We have all we need for fitting in xspec but, sadly, I overlokked the fact that the modulation factor is necessary for the pcubes. *** Quick fix: just copy the ixpe:obssim_gray:v12 files for the three DUs in the same folder adding the _gray suffix in the name. The gray filter does not change the modulation factor and this will work fine, modulo the fact that some of the header keyword will be inconsistent. This is not a big deal---probably one hour worth of work on my side. I will be in meetings most of the day, today, but I'll do my best to fix this and tag a new version of ixpeobssim by tomorrow night. I opened My apologies for the inconvenience, and thanks for helping debug this! |
It worked in unweighted case giving larger PD below 4keV. It did not work in weighted case giving me the following error: Traceback (most recent call last): Cheers, Michal. |
And this is correct, as well. For the PCUBE you want to use the weighted file with the SIMPLE prescription. (When I said "leave it alone" yesterday I was referring to the spectro-polarimetric fit in XSPEC only. The PCUBE is the very reason we have files with the simple prescription in the first place.) So for a weighted PCUBE you need to specify I know this sounds overly complicated---I have presented this multiple times at the SASWG telecons and I keep getting confused myself. Good that we have a sensible book-keeping in place within the response files and that xpbin is equipped with a check preventing people to do the wrong thing 😄 Luca |
...no, still the same error... M. File "/usr/local/share/IXPEobssim/ixpeobssim/core/pipeline.py", line 378, in xpbin |
And I now believe we really need a code change. The culprit appears to be
in ixpeobssim/irf/init.py |
And I now think we should not add more file, and handle the gray filter via a command-line option in the proper place, see issue #712 |
Pull request #716 |
Shipped in 30.6.0 |
Originally reported by Michal:
Dear Luca,
I have tried unweighted and weighted with irfname='ixpe:obssim_gray:v12' and irfname='ixpe:obssim_gray_alpha075:v12', respectively and it did not work
Input file /usr/local/share/IXPEobssim/ixpeobssim/caldb/ixpe/gpd/cpf/modfact/ixpe_d1_obssim_gray_mfact_v012.fits does not exists
and
Input file /usr/local/share/IXPEobssim/ixpeobssim/caldb/ixpe/gpd/cpf/modfact/ixpe_d1_obssim_gray_alpha075_mfact_v012.fits does not exists
In the directory modfact there are no gray filter responses. I am using ixpeobssim v.30.5.0.
Cheers,
Michal.
The text was updated successfully, but these errors were encountered: