-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy buffer view when iterating on file #10
Conversation
Seems that |
Yeah please - or just generate a file into /tmp during the test. |
Let me know when #9 gets merged so I can rebase on it to make build successful 👍 |
Merged :-) |
Should work now 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks :-)
Thanks a lot! My memory is a bit fuzzy about whether it only impacted deployctl or deno deploy too but if the later also uses this polyfill it may also need to be updated |
released 0.2.0 now. Deno Deploy does not use this polyfill. |
Closes #8
As @lucacasonato debugged in denoland/deno#10467, scrambled response output on large files may occur because the buffer is not copied so its content may change between iterations
Unless it has changed, this module is used by deno deploy and thus causing problems on it when trying to load large local files (current workaround was to use raw.githubusercontent instead of fetching local files)
It requires the patch for
- writable: true
from #9 to work, I left it out to avoid conflicts with it 👍