Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for large file #4

Closed
wants to merge 4 commits into from
Closed

test: add test for large file #4

wants to merge 4 commits into from

Conversation

satyarohith
Copy link
Contributor

@satyarohith satyarohith commented Mar 30, 2021 •
edited
Loading

This PR introduces several changes:

  • Upgrades dependencies and fixes tests.
  • disables windows in tests temporarily
  • adds a test for large file

Closes #3

@lucacasonato
Copy link
Owner

Why does this disable windows tests?

@satyarohith
Copy link
Contributor Author

CI says some format issues: https://github.com/lucacasonato/deno_local_file_fetch/runs/2226230871#step:4:29

I don't have access to a windows device - if this can be fixed that would be great.

@lucacasonato
Copy link
Owner

Landed the changes here in #5, #6, and #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for large files
2 participants
@satyarohith @lucacasonato