Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add createBucket & getBucket method #32

Merged
merged 20 commits into from
Nov 22, 2021
Merged

feat: add createBucket & getBucket method #32

merged 20 commits into from
Nov 22, 2021

Conversation

c4spar
Copy link
Contributor

@c4spar c4spar commented Nov 6, 2021

closes #31

This was referenced Nov 7, 2021
Open
Open
@c4spar c4spar mentioned this pull request Nov 7, 2021
Open
@c4spar c4spar mentioned this pull request Nov 8, 2021
Open
lucacasonato
lucacasonato reviewed Nov 10, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
lucacasonato
lucacasonato reviewed Nov 10, 2021
View reviewed changes
Copy link
Owner

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a way to get from S3 to an existing S3Bucket with all the details access keys etc set.

@c4spar
Copy link
Contributor Author

c4spar commented Nov 11, 2021

I agree, I also suggested in one of the other PR's to add a getBucket method. Will do 👍

c4spar and others added 2 commits November 11, 2021 19:20
@c4spar
add getBucket method
bffc48e
@c4spar @lucacasonato
fix example
c9c3104 
Co-authored-by: Luca Casonato <lucacasonato@yahoo.com>
@c4spar c4spar changed the title feat: add createBucket method feat: add createBucket & getBucket method Nov 11, 2021
@c4spar
Copy link
Contributor Author

c4spar commented Nov 12, 2021

I think I'm done 🙂

lucacasonato
lucacasonato approved these changes Nov 22, 2021
View reviewed changes
Copy link
Owner

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :-)

@lucacasonato lucacasonato merged commit 11732fd into lucacasonato:main Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for creating a new bucket
2 participants
@c4spar @lucacasonato