fix(signer): Strictly follow qp canonicalization spec #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54 for prefix keys containing spaces and other idiosyncratic special characters (e.g.
~, which was also previously failing).This is from my fork, so it also incorporates the changes from and supersedes #53 and fixes #52.
encodeUriS3is moved intodeno_aws_sign_v4as it doesn't make sense to have a bidirectional dependency — it's now also used for encoding the query params per AWS's spec.If this is ever merged, you'll probably also want to change the
deps.tsimport to the deno.land/x URL for the updateddeno_aws_sign_v4.