Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieving manifest for single platform #23

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

lucacome
Copy link
Owner

@lucacome lucacome commented Jan 28, 2023

When the container is built for a single platform, the API responds with application/vnd.docker.distribution.manifest.v1+json if it's not in the list of accepted formats.

This fix adds application/vnd.docker.distribution.manifest.v2+json to the accept list to read single platform manifests.
It assumes that the platform is linux/amd64 since the manifest doesn't contain the info.

Fixes #22

@lucacome lucacome self-assigned this Jan 28, 2023
@lucacome lucacome marked this pull request as draft January 28, 2023 09:54
@lucacome lucacome marked this pull request as ready for review January 30, 2023 19:05
@lucacome lucacome merged commit f50d564 into main Jan 30, 2023
@lucacome lucacome deleted the fix/single-manifest branch January 30, 2023 19:06
@lucacome lucacome added the bug Something isn't working label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow run failed
2 participants