-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap eval call in window context #5
Conversation
@@ -10,6 +10,9 @@ module.exports = function(scripts, options) { | |||
var results = scripts.map(function(content) { | |||
|
|||
try { | |||
(function() { | |||
eval(content.text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eval can be harmful.
@@ -10,7 +10,9 @@ module.exports = function(scripts, options) { | |||
var results = scripts.map(function(content) { | |||
|
|||
try { | |||
eval(content.text); | |||
(function() { | |||
eval(content.text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eval can be harmful.
It creates too much noise in the graph and gives no benefit
@@ -20,6 +20,12 @@ module.exports = function (options) { | |||
module: function(name, deps) { | |||
var module; | |||
|
|||
if(deps) { | |||
var ngMaterialDepIndex = deps.indexOf('ngMaterial'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
No description provided.