performance optimizations

lucaong · Sep 18, 2020 · ace6f25 · ace6f25
1 parent 20bca94
commit ace6f25
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/src/MiniSearch.ts b/src/MiniSearch.ts
@@ -944,7 +944,7 @@ const combinators: { [kind: string]: CombinatorFunction } = {
       } else {
         combined[documentId].score += score
         combined[documentId].score *= 1.5
-        combined[documentId].terms = [...combined[documentId].terms, ...terms]
+        combined[documentId].terms.push(...terms)
         Object.assign(combined[documentId].match, match)
       }
       return combined

diff --git a/src/SearchableMap/SearchableMap.ts b/src/SearchableMap/SearchableMap.ts
@@ -263,9 +263,16 @@ class SearchableMap<T = any> implements IterableSet<T> {
 
 const trackDown = <T = any>(tree: RadixTree<T> | undefined, key: string, path: Path<T> = []): [RadixTree<T> | undefined, Path<T>] => {
   if (key.length === 0 || tree == null) { return [tree, path] }
-  const nodeKey = Object.keys(tree || {}).find(k => k !== LEAF && key.startsWith(k))
-  if (nodeKey === undefined) { return trackDown(undefined, '', [...path, [tree, key]]) }
-  return trackDown(tree[nodeKey] as RadixTree<T>, key.slice(nodeKey.length), [...path, [tree, nodeKey]])
+
+  const nodeKey = Object.keys(tree).find(k => k !== LEAF && key.startsWith(k))
+
+  if (nodeKey === undefined) {
+    path.push([tree, key]) // performance: update in place
+    return trackDown(undefined, '', path)
+  }
+
+  path.push([tree, nodeKey]) // performance: update in place
+  return trackDown(tree[nodeKey] as RadixTree<T>, key.slice(nodeKey.length), path)
 }
 
 const lookup = <T = any>(tree: RadixTree<T>, key: string): RadixTree<T> | undefined => {