fix other issues caused by fields or terms matching default propertie…

…s of object

src/MiniSearch.js

@@ -180,7 +180,7 @@ class MiniSearch {
   */
   add (document) {
     const { extractField, tokenize, processTerm, fields, idField } = this._options
-    if (document[idField] == null) {
+    if (getOwnProperty(document, idField) == null) {
       throw new Error(`MiniSearch: document does not have ID field "${idField}"`)
     }
     const shortDocumentId = addDocumentId(this, document[idField])
@@ -254,7 +254,7 @@ class MiniSearch {
   remove (document) {
     const { tokenize, processTerm, extractField, fields, idField } = this._options
 
-    if (document[idField] == null) {
+    if (getOwnProperty(document, idField) == null) {
       throw new Error(`MiniSearch: document does not have ID field "${idField}"`)
     }
 
@@ -265,7 +265,7 @@ class MiniSearch {
       throw new Error(`MiniSearch: cannot remove document with ID ${document[idField]}: it is not in the index`)
     }
 
-    fields.filter(field => document[field] != null).forEach(field => {
+    fields.filter(field => getOwnProperty(document, field) != null).forEach(field => {
       const tokens = tokenize(extractField(document, field) || '', field)
 
       tokens.forEach(term => {
@@ -572,7 +572,7 @@ class MiniSearch {
     options = { ...this._options.searchOptions, ...options }
 
     const boosts = (options.fields || this._options.fields).reduce((boosts, field) =>
-      ({ ...boosts, [field]: boosts[field] || 1 }), options.boost || {})
+      ({ ...boosts, [field]: getOwnProperty(boosts, field) || 1 }), options.boost || {})
 
     const {
       boostDocument,

src/MiniSearch.test.js

@@ -40,6 +40,13 @@ describe('MiniSearch', () => {
       }).toThrowError('MiniSearch: document does not have ID field "foo"')
     })
 
+    it('throws error if the document does not have the ID field, even when named like a default object property', () => {
+      const ms = new MiniSearch({ idField: 'constructor', fields: ['title', 'text'] })
+      expect(() => {
+        ms.add({ text: 'I do not have an ID' })
+      }).toThrowError('MiniSearch: document does not have ID field "constructor"')
+    })
+
     it('rejects falsy terms', () => {
       const processTerm = term => term === 'foo' ? null : term
       const ms = new MiniSearch({ fields: ['title', 'text'], processTerm })
@@ -174,6 +181,23 @@ describe('MiniSearch', () => {
       }).toThrowError('MiniSearch: document does not have ID field "foo"')
     })
 
+    it('throws error if the document does not have the ID field, even if named like a default property of object', () => {
+      const ms = new MiniSearch({ idField: 'constructor', fields: ['title', 'text'] })
+      expect(() => {
+        ms.remove({ text: 'I do not have an ID' })
+      }).toThrowError('MiniSearch: document does not have ID field "constructor"')
+    })
+
+    it('does not crash when the document has field named like default properties of object', () => {
+      const ms = new MiniSearch({ fields: ['constructor'] })
+      const document = { id: 1 }
+      ms.add(document)
+
+      expect(() => {
+        ms.remove(document)
+      }).not.toThrowError()
+    })
+
     it('does not reassign IDs', () => {
       ms.remove(documents[0])
       ms.add(documents[0])
@@ -423,6 +447,17 @@ describe('MiniSearch', () => {
       expect(results[0].score).toBeGreaterThan(results[1].score)
     })
 
+    it('computes a meaningful score when fields are named liked default properties of object', () => {
+      const ms = new MiniSearch({ fields: ['constructor'] })
+      ms.add({ id: 1, constructor: 'something' })
+      ms.add({ id: 1, constructor: 'something else' })
+
+      const results = ms.search('something')
+      results.forEach((result) => {
+        expect(Number.isFinite(result.score)).toBe(true)
+      })
+    })
+
     it('searches in the given fields', () => {
       const results = ms.search('vita', { fields: ['title'] })
       expect(results).toHaveLength(1)